fix(301): Sync on startup 'taking too long to load' #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#301
Selecting the "Sync on startup" setting and restarting Obsidian results in a "taking a long time to load" error. Currently the only workaround is to open the vault in safe mode, disable the option, and restart Obsidian.
This change moves the syncOnBoot logic to an
onLayoutReadycallback as described in Obsidian's best practices guide:https://docs.obsidian.md/plugins/guides/load-time
With this change, Obsidian is able to load the vault as expected, and the highlight sync is performed in the background without pressing the "Sync..." button.