Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rust 1.71.0+ compatibility #130

Merged
merged 5 commits into from
Oct 29, 2023
Merged

Fix Rust 1.71.0+ compatibility #130

merged 5 commits into from
Oct 29, 2023

Commits on Oct 25, 2023

  1. Keep Rustfmt happy

    @haimgel
    haimgel committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    2369a31 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded boxing

    @haimgel
    haimgel committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    9f4c4bb View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Revert "Remove unneeded boxing" 

    This boxing is not unneeded, it's actually
required by libusb on MacOS/Linux.

This reverts commit 9f4c4bb.
    @haimgel
    haimgel committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    44acc86 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. Return boxed value PnPDetectWindows:new: 

    PnPDetectWindows structure cannot be freely copied/moved around because a pointer to self is stored in the created Window class.

This code was working in Rust prior to 1.70 apparently just because Rust optimized PnPDetectWindows:new in a way that did not cause the structure to be copied; that no longer works in Rust 1.71+
    @haimgel
    haimgel committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    03716a8 View commit details
    Browse the repository at this point in the history

  2. Make PnPDetectLibusb the same signature as PnPDetectWindows

    @haimgel
    haimgel committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    e260e5b View commit details
    Browse the repository at this point in the history