Don't switch source when already set #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been testing this (on Alpine Linux) and it seems to be working quite well! I hope it can be reviewed/merged soon 😄 |
|
I just tested this and it doesn't work for me: This is officially the monitor's fault, I think - 0xf0f is of course not what it was set to. However I don't know if some of these are option bits that need to be masked out (I am not familiar with the DDC commands in question). |
Co-authored-by: George Hilliard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When (re)starting the service, my monitor would flicker off while it re-applied the input.
Since there already was code to get the current source, I decided to add a check to skip setting the source if already set to the desired value.
Not really familiar with rust, so feel free to edit or make your own version.
Also, it might make sense to make this configurable, as mentioned in #30 and xkcd 1172.