Skip to content
This repository has been archived by the owner on Nov 5, 2023. It is now read-only.

Commit

Permalink
Changes for version update and minor improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
@hakandundar34coding
hakandundar34coding committed Oct 23, 2022
1 parent 9447eb8 commit e4aa059
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
8 changes: 8 additions & 0 deletions debian/changelog
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
system-monitoring-center (1.29.0) unstable; urgency=medium

* New: Support for Flatpak packaging
* Changed: Single project branch for all packaging types
* Minor code improvements

-- Hakan Dündar <[email protected]> Sun, 23 Oct 2022 17:00:00 +0300

system-monitoring-center (1.28.0) unstable; urgency=medium

* New: Option for language selection
Expand Down
9 changes: 6 additions & 3 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,17 @@ def files_in_folder(folder):
sys.argv.remove("--flatpak_package")

# Python package
elif "egg_info" in sys.argv:
package_type_var = "python_package"
elif "egg_info" in sys.argv or "sdist" in sys.argv or "bdist_wheel" in sys.argv:
for argv in sys.argv:
if "/in_process/_in_process.py" in argv:
package_type_var = "python_package"

# Debian, RPM, Arch Linux another other package
else:
package_type_var = "debian_rpm_archlinux_or_another_package"

print("_____Package Type: " + package_type_var + "_____")

print("\n" + "_____package_type: " + package_type_var + "_____" + "\n")



Expand Down

11 comments on commit e4aa059

@hakandundar34coding
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theofficialgman
Hello. It has been a long time since the last conversation. Newer versions of the application are available in a single branch. You may update your script(s) for the changes. I do not know if auto-update script for this application. Because there are not big changes for Github release download numbers of the application after new packages are published. But it looks like the download count (pi-apps repository) of the application is not small.

@theofficialgman
Copy link
Contributor

@theofficialgman theofficialgman commented on e4aa059 Oct 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakandundar34coding thanks for keeping me updated. yes we have auto-updating scripts at pi-apps for this application (run once a week on Wednesday so it hadn't caught the change yet). you can see our github actions made a commit last week https://github.com/Botspot/pi-apps/blob/master/apps/System%20Monitoring%20Center/install

I'm not sure if github tracks wget downloads from releases or not but users do get update notifications when you publish a new release.

we have analytics tracking at pi-apps for new installs and uninstalls but not updates.

System-Monitoring-Center

we are in the process of switching from bitly to self hosted shlink instance so once that is done I may add update tracking and make these numbers public (ie: graphed) as well.

@hakandundar34coding
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theofficialgman

I'm not sure if github tracks wget downloads from releases or not but users do get update notifications when you publish a new release.

There were big download number changes (such as 500-700 downloads per update) long time ago. The behavior may have been changed for wget.

@hakandundar34coding
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linuxlite
Can you change version number of the forked application? It is bigger than the version of the main branch of the application. Currently there is a big difference between these numbers but this may be a problem in newer versions of the main branch.

I have seen that some users download .deb file of the forked version from distribution repository directly. There are some discussions about this situation on some forums. Some users may think that the forked version is newer. Some of the reasons for this:

  • Some of the features (such as Startup tab) are removed because of complexity.
  • It may be hard for some users to track version dates from the project page.

@hakandundar34coding
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theofficialgman
For Ubuntu 18, do not update the application to versions bigger than v1.29.0. Several tabs do not work. v1.29.0 version of the application works on Ubuntu 18.

There are a lot of code changes for getting system/performance information in order to support Flatpak packaging. Because there would be a lot of new code and the code would be very complex.

I will write comment if the compability problems are fixed for Ubuntu 18.

@hakandundar34coding
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theofficialgman
The bugs are fixed in v1.32.0. You can update the application in Pi-apps if it can be updated before Wednesday.

@theofficialgman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theofficialgman The bugs are fixed in v1.32.0. You can update the application in Pi-apps if it can be updated before Wednesday.

Thanks. I can run the update action whenever I want, we just have the script running on Wednesday by default to limit update notifications to our users. I'll update it when I get back to a computer.

@hakandundar34coding
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theofficialgman
Additionally,
You can write if you do not want to get messages/comments.

@theofficialgman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakandundar34coding you are welcome to continue notifying me. I find it helpful since my time it split across many things.

@theofficialgman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakandundar34coding just to update you on this. I have added update analytics tracking to pi-apps for all apps about a week and a half ago. you can view the last two weeks of analytics for any app here: https://github.com/Botspot/pi-apps-analytics/blob/main/Update-Graphs.md and system monitoring center is specifically viewable here always:

System-Monitoring-Center

@hakandundar34coding
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theofficialgman
It is very useful for tracking version changes in one place.
I will add total download numbers from Pi-apps to the project page.

Please sign in to comment.