Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit, egui and vulkano #53

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

Letronix624
Copy link
Contributor

@Letronix624 Letronix624 commented Jan 13, 2024

Updates winit egui vulkano and the crates below that.

Stays a draft as long as vulkano has not released it's changes.

@hakolao
Copy link
Owner

hakolao commented Jan 15, 2024

You could update this draft using a link to a specific commit id from vulkano repo in Cargo.toml. That way we could do

Wait for vulkano 0.25 to roll out and revisit this draft, easily applying the new utils version with winit 0.29 and therefore avoid being current until Vulkano is.

And meanwhile you could use this branch in your project. And when 0.25 is out, just replace the dependency with that.

Thoughts?

I personally prefer the simplicity of using vulkano-util in the examples keeping them clean.

@Letronix624
Copy link
Contributor Author

Yes, I also had that idea. Alright

@Letronix624 Letronix624 changed the title Update winit and egui Update winit and egui and vulkano Jan 16, 2024
@Letronix624 Letronix624 changed the title Update winit and egui and vulkano Update winit, egui and vulkano Jan 16, 2024
@hakolao
Copy link
Owner

hakolao commented Apr 9, 2024

Happy to get this merged when vulkano 0.35 is out, and make a release.

Letronix624 and others added 6 commits July 25, 2024 15:26
vulkano -> upstream, winit -> 0.30, egui -> 0.29
This is in order to avoid random breakage when Vulkano gets an update.

Gets removed as soon as Vulkano releases a new version.
rename RecordingCommandBuffers and CommandBuffers back to AutoCommandBufferBuilder and their previous names
Use PrimaryCommandBufferAbstract again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants