Some changes that helped me awhile ago #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to use multi-submission ones.
It's wasteful for egui to have their own.
Creating and submitting command buffers is somewhat expensive, so consolidate that a bit.
The point of secondary command buffers is a) creating secondary buffers on multiple threads or b) editing a long-lived command buffer by replacing secondary buffer content. This egui backend does neither. Change draw_on_subpass_image to take a mutable reference to a command buffer instead of returning one, so that users can use their own command buffer to better batch rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm cleaning up my repos and forks and noticed that I had some changes for this crate that I used but didn't publish. They helped me for my project, so consider taking them.
Check the descriptions for each individual commit for changes and justifications.