Compatibility ggplot2 4.0.0 #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is just a simple reminder. |
|
Dear @haleyjeppson I urge you to merge this PR and submit to CRAN ASAP as ggmosaic is one of the packages with it's own reverse dependencies that also fail due to the issues in ggmosaic |
Collaborator
|
@thomasp85 @teunbrand thanks so much for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
We're preparing for a new major release for ggplot2 and found an issue with ggmosaic during a reverse dependency check.
This PR fixes the problems we found and think should be adressed in ggmosaic. These changes should be backwards compatible. This PR also makes #75 redundant.
We plan to release the new ggplot2 version in 3 weeks and hope these fixes can make their way to CRAN soon.
Best wishes,
Teun