Backport reverse_view to clean up some code #8486
Conversation
|
Side note: we should (again) examine if we can move to C++20 for Halide 20. (Google has been at C++20 for a while now. Are there still blockers at Adobe?) |
| if (it->is_fuse()) { | ||
| if (parallel.count(it->inner) || parallel.count(it->outer)) { | ||
| parallel.insert(it->old_var); | ||
| for (const auto &split : sched.splits()) { |
There was a problem hiding this comment.
This one is meant to be forward.
|
@abadams -- thanks for catching that! I went over all the other loops and they all have |
|
Nice cleanup. How complete is it? Did you already grep for all the rbegins/rends, or are there potentially more opportunities? |
I grepped for I should look for |
|
I made it through the new commit and didn't spot any issues. |
alexreinking
added
the
code_cleanup
|
Vulkan failures are unrelated |
I found it very useful to backport
reverse_viewfrom C++20 for the sake of writing readable backwards loops. Here, I addreverse_viewtoUtil.h. This allows us to simplify code in a lot of places.