Fix clang-tidy-19 errors #8509
Merged
Fix clang-tidy-19 errors #8509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
approved these changes
Dec 16, 2024
|
I think the change in HalideBuffer.h here caused #8534 It's supposed to take src by value because make_with_shape_of_helper mutates src.buf.dim in-place. |
|
A nice reminder that we should always wait for the tests to go green, even on trivial PRs. |
|
I'm confused about this diagnosis -- if it's mutating it in-place then how is it compiling now (since it's a const ref)? |
|
It's taking a copy of a pointer member that points to storage contained within the same class (the dims array), and mutating things through that pointer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.