Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully fix flaky mullapudi reorder test #8542

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

abadams
Copy link
Member

@abadams abadams commented Dec 24, 2024

This tested vectorized code against scalar code, but the scalar code was something that could be potentially be optimized by llvm quite cleverly - it was just a linear combination of the loop variables. This changes the test to be less of a weird corner case, while still preserving the important property - the evaluation of f is fine under any storage ordering. Hopefully this will make it flake less often.

@abadams abadams merged commit c2d5ea3 into main Dec 27, 2024
19 checks passed
@alexreinking
Copy link
Member

Still flaking on arm-64-osx:

Autoscheduler time (1) is slower than expected:
======================
Manual time: 10.5701ms
Auto time: 22.7106ms
======================

https://buildbot.halide-lang.org/master/#/builders/171/builds/350

@abadams
Copy link
Member Author

abadams commented Dec 29, 2024

Sigh. Not as badly at least. Previously the error threshold was set to 15x slower. I set it to 2x slower after fixing it, but maybe that wasn't conservative enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants