Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable asan testing #231

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
+17 −10
Draft

Re-enable asan testing #231

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
beccc02
Re-enable asan testing
steven-johnson Jun 2, 2023
77dc2b3
Add ASAN_SYMBOLIZER_PATH
steven-johnson Jun 2, 2023
60d137e
Update master.cfg
steven-johnson Jun 2, 2023
7fe2e2b
Update master.cfg
steven-johnson Jun 2, 2023
a5e3bbd
Merge branch 'master' into srj/enable-asan
steven-johnson Jun 2, 2023
69b1a4f
Merge branch 'master' into srj/enable-asan
steven-johnson Jun 23, 2023
ba7916f
Update master.cfg
steven-johnson Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions master/master.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ c['workers'] = [Worker(n,
properties={'WORKER_BUILD_PARALLELISM': cfg.j}) for n, cfg in _WORKERS]

_SANITIZERS = [
# 'asan', # TODO: weird error about precompiled header file
'asan',
'fuzzer', # this isn't *technically* a sanitizer, but is close enough that it's a good fit
]

Expand Down Expand Up @@ -715,7 +715,7 @@ def get_llvm_cmake_definitions(builder_type):
'LLVM_ENABLE_OCAMLDOC': 'OFF',
'LLVM_ENABLE_RTTI': 'ON',
'LLVM_ENABLE_TERMINFO': 'OFF',
'LLVM_ENABLE_WARNINGS': 'ON', # silence them, it's not like we're gonna fix them
'LLVM_ENABLE_WARNINGS': 'OFF', # silence them, it's not like we're gonna fix them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the old misleading comment

'LLVM_ENABLE_ZLIB': 'ON',
'LLVM_ENABLE_ZSTD': 'OFF',
'LLVM_INCLUDE_BENCHMARKS': 'OFF',
Expand Down Expand Up @@ -814,6 +814,8 @@ def add_env_setup_step(factory, builder_type, enable_ccache=False):
'CC': cc,
'CXX': cxx,
'LD': ld,
# Only needed for ASAN builds, but easier to just always specify
'ASAN_SYMBOLIZER_PATH': get_llvm_install_path(builder_type, 'bin/llvm-symbolizer')
}

# TODO: HALIDE_NODE_JS_PATH is only necessary until EMSDK updates their built-in version of Node
Expand Down Expand Up @@ -966,14 +968,19 @@ def add_halide_cmake_build_steps(factory, builder_type):
definitions=get_halide_cmake_definitions(builder_type),
options=get_halide_cmake_options(builder_type, build_dir)))

factory.addStep(
ShellCommand(name='Build Halide',
description='Build Halide',
locks=[performance_lock.access('counting')],
haltOnFailure=True,
workdir=build_dir,
env=Property('env'),
command=get_cmake_build_command(builder_type, build_dir, targets=['all', 'install'])))
# Don't do this initial build:
# We always follow this with a call to add_halide_cmake_test_steps(),
# which will reconfigure CMake and rebuild. For most targets, the extra
# build is close to a no-op (building for `host` again), but for Sanitizer
# builds, it's just wasted effort.
# factory.addStep(
# ShellCommand(name='Build Halide',
# description='Build Halide',
# locks=[performance_lock.access('counting')],
# haltOnFailure=True,
# workdir=build_dir,
# env=Property('env'),
# command=get_cmake_build_command(builder_type, build_dir, targets=['all', 'install'])))


def add_halide_cmake_package_steps(factory, builder_type):
Expand Down