Improved way to create metavars coloured strings #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atteggiani
changed the title
hamdanal
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Thank you so much @atteggiani. This fixes broken multiline metavars styling once and for all. Thanks for doing several iterations and for seeing this to the end.
hamdanal
added a commit
that referenced
this pull request
Jul 6, 2024
Fixes #125. Fixes #127. - [x] Implemented the [suggestion](#127 (comment)) for the creation of the metavars strings and Spans. - [x] The implementation avoids using regex and only produces the coloured strings once for all help parts (usage and argument description). - [x] A few minor modifications were implemented from the original suggestion. - [x] Added test for metavars that span within multiple lines if terminal window is not big enough (see #125). - [x] 100% coverage on all tested python versions. --------- Co-authored-by: Ali Hamdan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125.
Fixes #127.