Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enumeration class #154

Conversation

KennyGitStyle
Copy link

#28 "Use enumeration instead of enum in domain model" - I have made this change.

@hamed-shirbandi
Copy link
Owner

Hi @KennyGitStyle

Thank you so much for your time and contribution.

The issue needs more changes to be done, if you still like to do it see the following tips:
(I should have added this tips to the issue before)

  • Remove BoardMemberAccessLevel and UserType from contract enums because they are not used anymore
  • Remove ContractEnumeration.cs from Contracts because they belong to Domain Model
  • Move your BoardCardType definition into CardType value object
  • Refactor Card behaviors in Board aggregate with new CardType value object
  • Refactor Card Domain Events and Integration Events with new CardType value object (in the Read side, we still want to use CardType enum)
  • Refactor Card use cases with new CardType value object. Here we need to prevent the outside world to be aware of our changes, so try to map the CardType enum given from the request to CardType value object in use cases then pass it to the Domain behaviors

Now, if the task is large, It's no problem ignoring it. You're always welcome to do another tasks. Also, if you have any question, I am glad to help.

@KennyGitStyle
Copy link
Author

Ok, thats fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants