Conversation
|
Have you figured out how to determine what currency an account is using? I can do it with SimpleFin which wraps mx.com - but haven't seen it in monarch |
|
that might be an overkill for this since it runs as a script anyway, we can just have the user fill a dict with the currencies of each account they want conversions on. |
hammem
left a comment
hammem
left a comment
There was a problem hiding this comment.
@angadsingh , I appreciate you adding this, but I don't think this belongs in the library. It will add multiple dependencies to the build, processing of zip files on disk, and other complexities that may be a lot to keep functional or introduce errors on end-user environments that are challenging to debug.
If folks frequently need currency conversion, it's worth considering, but this doesn't seem central to having a Python API for Monarch.
|
I actually wrote a separate lib wrapping yours :) so we can prob ignore
these PRs :)
https://github.com/jeeftor/monarchmoney-typed
…On Sun, Jan 19, 2025 at 9:02 AM hammem ***@***.***> wrote:
***@***.**** commented on this pull request.
@angadsingh <https://github.com/angadsingh> , I appreciate you adding
this, but I don't think this belongs in the library. It will add multiple
dependencies to the build, processing of zip files on disk, and other
complexities that may be a lot to keep functional or introduce errors on
end-user environments that are challenging to debug.
If folks frequently need currency conversion, it's worth considering, but
this doesn't seem central to having a Python API for Monarch.
—
Reply to this email directly, view it on GitHub
<#113 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRQ4X5WLDJZGP5NCHZFT232LPEAPAVCNFSM6AAAAABLXJRTL2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRRGA2DAOBRGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
3 participants
converts transactions and account balance history between currencies (default: USD to CAD).
it is meant to be run periodically. will resume from its last state. state is saved inside MM itself. transactions are tagged (e.g. a tag like USD2CAD - you create the tag). the original amount is put in the "notes" of the transaction in case you want to rollback.
account balance history is also checkpointed (creates a special checkpoint transaction with $0 balance - just to keep the last conversation date).
created this to use MM in canada.