Conversation
hammem
requested changes
Jan 19, 2025
Owner
hammem
left a comment
hammem
left a comment
There was a problem hiding this comment.
Thanks for the refactor, @jeeftor ! If you could, please break this apart, so I can more easily ensure a push to PyPI won't result in a broken version. Or, please ensure the new tests you wrote -- thank you again! -- are part of the CI/CD workflows that are run today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like your lib but I find it is a little hard to look through because you've inlined all the GraphQL queries.
I made a
const.pyfile and moved the GET query definitions into it - so you can take a look. I'm hoping I'll be able to auto-generate data classes for return data and having the queries in their own variables "might" allow one to automate this.Feel free to ignore if you want - but I thought I'd offer a potential improvement in readability ...
Ultimately I would suggest all queries get externalized - but I decided to start with the get's for now.