Skip to content

Add Holdings-Related Functionality#151

Open
edwisdom wants to merge 2 commits intohammem:mainfrom
edwisdom:feat/add_and_remove_holdings
Open

Add Holdings-Related Functionality#151
edwisdom wants to merge 2 commits intohammem:mainfrom
edwisdom:feat/add_and_remove_holdings

Conversation

@edwisdom
Copy link

@edwisdom edwisdom commented Jun 5, 2025

Description

This PR accomplishes the following:

  1. Adds the ability to get a holding ID by ticker symbol
  2. Adds a function to manually add a holding by ticker symbol
  3. Adds a function to delete a holding by holding ID

All of this functionality together allows someone to programmatically update the investment holdings for their Monarch accounts.

keithah added a commit to keithah/monarchmoney-enhanced that referenced this pull request Sep 2, 2025
- Add get_security_details() for ticker symbol lookup
- Add create_manual_holding() for creating holdings by security ID
- Add create_manual_holding_by_ticker() for creating holdings by ticker symbol
- Add delete_manual_holding() for removing holdings
- Update CHANGELOG with original PR references

Implements functionality from:
- PR hammem#151: hammem#151

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@gabevf
Copy link

gabevf commented Sep 3, 2025

would love to be able to update holding amounts as well

keithah added a commit to keithah/monarchmoney-enhanced that referenced this pull request Sep 3, 2025
- Add get_security_details() for ticker symbol lookup
- Add create_manual_holding() for creating holdings by security ID
- Add create_manual_holding_by_ticker() for creating holdings by ticker symbol
- Add delete_manual_holding() for removing holdings
- Update CHANGELOG with original PR references

Implements functionality from:
- PR hammem#151: hammem#151

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
keithah pushed a commit to keithah/monarchmoney-enhanced that referenced this pull request Sep 4, 2025
Integrated highly valuable features from community pull requests:

HOLDINGS MANAGEMENT (PR hammem#151):
• get_holding_by_ticker() - Find holdings by ticker symbol
• add_holding_by_ticker() - Add holdings programmatically
• remove_holding_by_ticker() - Remove holdings by ticker
• update_holding_quantity() - Update share quantities
• Complete programmatic investment portfolio management

TRANSACTION FILTERING (PR hammem#148):
• Enhanced get_transactions() with amount filtering
• is_credit parameter for income/expense filtering
• abs_amount_range for precise amount range filtering
• Support for min/max ranges and exact amounts
• Advanced transaction analysis capabilities

TRANSACTION SUMMARY CARD (PR hammem#140):
• get_transactions_summary_card() method added
• Provides UI-accurate transaction counts
• Better data consistency with Monarch web interface

CATEGORIES & MERCHANTS API (PR hammem#128):
• get_transaction_categories() - All available categories
• get_merchants() - Merchants with search & filtering
• get_merchant_details() - Detailed merchant information
• get_category_details() - Category statistics & insights
• Enhanced transaction management capabilities

ADDITIONAL ENHANCEMENTS:
• Added comprehensive PR features demo script
• Enhanced InvestmentService with 6 new methods
• Enhanced TransactionService with 7 new methods
• Full backward compatibility maintained
• All tests passing (58/58)

These community contributions significantly expand the library's
capabilities for investment management and transaction analysis.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants