Show transactions from all accounts by default, and add hiddenByAccount to returned fields#170
Show transactions from all accounts by default, and add hiddenByAccount to returned fields#170grablair wants to merge 6 commits intohammem:mainfrom
Conversation
…nt to returned fields fixes hammem#168
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for filtering transactions based on their visibility, specifically including or excluding transactions from accounts hidden from lists, reports, and budgets.
- Adds a new
show_all_transactionsparameter to theget_transactionsmethod with a default value ofTrue - Adds the
hiddenByAccountfield to the GraphQL query fragment to retrieve this property for each transaction - Implements the filtering logic to set
transactionVisibilityfilter to "all_transactions" when the parameter isTrue
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Pretty strange you've updated authorship and the pypi link @grablair. Was that intentional? |
|
@alex-gable @hammem hasn't committed to the repo for almost a year now, so that may have been an effort to keep releases flowing. If this repo remains inactive, it may be worth forking and moving community efforts to the fork given that it seems like the current version may not actually work ETA: that being said, the diff contains a reference to a repo that doesn't actually exist (hammem/monarchmoney-grablair) |
fixes #168
A few months ago, Monarch changes the "Hidden from budgets and reports" into "Hidden from transaction list, budgets, and reports", which is a significant behavior change.
This modifies the transaction list API call to list all transactions from all accounts, but also add a
hiddenByAccountfield to the returned accounts, so that information is still available.This is on by defaults, but can be turned off by a new parameter on the get_transactions method.