Assorted fixes #106
Merged
Assorted fixes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xymph
reviewed
Jul 4, 2021
|
Other than the one minor remark, everything looks correct and complete. |
waldyrious
force-pushed
the
assorted-fixes
branch
from
fc115aa to
a8bdcfa
Compare
|
Updated per your suggestion. Feel free to merge whenever is convenient to you. By the way, I am out of time for today, but I should be able to rebase #102 tomorrow. |
|
That's a wrap. Great progress yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-ups to PR #100:
token()function, as discussed hereOther changes:
All of these fixes were authored by @Xymph, and are being extracted from #102 to keep that one focused on the release preparations.