Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v0.14.0 release #120

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Conversation

Xymph
Copy link
Collaborator

@Xymph Xymph commented Aug 23, 2021

Release summary:

"This release adds support for the maxlag parameter and for getting/setting the user agent, changes API calls from deprecated PHP format to JSON format, and improves PHPDoc commentary and USAGE.md.
It requires MediaWiki v1.27 or newer. For more details on these changes, including links to the corresponding pull requests, please check the Changelog."

@Xymph Xymph requested a review from waldyrious August 23, 2021 19:35
@waldyrious
Copy link
Collaborator

waldyrious commented Aug 23, 2021

It requires MediaWiki v1.27 or newer.

This wording seems to suggest that this wasn't the case with 0.13. Maybe we could either remove this sentence, or change its start to, for example, "Like 0.13, this version requires...". WDYT?

ps - I had never seen "commentary" used in the context of code comments. It's pretty nice, I'm going to start using it!

Copy link
Collaborator

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the PR diff all look good to me! 👍

@Xymph
Copy link
Collaborator Author

Xymph commented Aug 23, 2021

This wording seems to suggest that this wasn't the case with 0.13. Maybe we could either remove this sentence, or change its start to, for example, "Like 0.13, this version requires...". WDYT?

Agreed, "Since v0.13.0 Wikimate requires..." would be clearer.

ps - I had never seen "commentary" used in the context of code comments. It's pretty nice, I'm going to start using it!

Uhm, what are you referring to?

@waldyrious
Copy link
Collaborator

ps - I had never seen "commentary" used in the context of code comments. It's pretty nice, I'm going to start using it!

Uhm, what are you referring to?

From the release summary in this PR's opening comment:

... and improves PHPDoc commentary and USAGE.md.

@Xymph
Copy link
Collaborator Author

Xymph commented Aug 23, 2021

Ah, the word itself. Haha, okay. 😄

@Xymph Xymph merged commit e562299 into hamstar:master Aug 24, 2021
@Xymph Xymph deleted the prepare-release-0.14.0 branch August 24, 2021 09:00
@Xymph
Copy link
Collaborator Author

Xymph commented Aug 24, 2021

Release tagged, Packagist and MediaWiki library list updated.

@waldyrious
Copy link
Collaborator

waldyrious commented Aug 24, 2021

Packagist and MediaWiki library list updated.

I guess we should add those steps to the instructions too?

Also, I just noticed https://en.wikipedia.org/wiki/Wikipedia:PHP_bot_framework_table, which doesn't need to be updated with every release, but could be updated to include you as a maintainer, and soon to tick the "Exclusion compliant" box :)

@Xymph
Copy link
Collaborator Author

Xymph commented Aug 24, 2021

Packagist and MediaWiki library list updated.

I guess we should add those steps to the instructions too?

I suppose that's sensible.

Also, I just noticed https://en.wikipedia.org/wiki/Wikipedia:PHP_bot_framework_table, which doesn't need to be updated with every release, but could be updated to include you as a maintainer, and soon to tick the "Exclusion compliant" box :)

Added. Ticking that box is post-1.0 in the current roadmap though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants