Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v1.1.0 release #156

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

Xymph
Copy link
Collaborator

@Xymph Xymph commented Jul 23, 2023

Release summary:

This release adds a new undelete method, supports the API's deletetalk parameter in the delete methods based on a new mechanism to handle version-dependent parameters of API modules, updates the dependency on rmccue/requests to v2.x, resolves several warnings, and improves code formatting and commenting. For more details on these changes, including links to the corresponding pull requests, please check the Changelog.

@Xymph Xymph requested a review from waldyrious July 23, 2023 12:00
@Xymph
Copy link
Collaborator Author

Xymph commented Jul 23, 2023

Obviously #155 needs to be merged first, but I don't know whether that will affect merge-ability of Changelog.md here. And if so, how to resolve that, so please advise.

Also, the release date needs to be updated in two places before the actual merge of this PR.

@Xymph Xymph force-pushed the prepare-release-1.1.0 branch from 98d89f0 to 0b7fe17 Compare July 24, 2023 18:32
@waldyrious
Copy link
Collaborator

Obviously #155 needs to be merged first, but I don't know whether that will affect merge-ability of Changelog.md here. And if so, how to resolve that, so please advise.

The edits from both PRs touch different lines of the file, so git is able merge them to without conflicts. I'll go ahead and rebase this branch, edit the release date and merge the PR :)

@waldyrious waldyrious force-pushed the prepare-release-1.1.0 branch from 0b7fe17 to 5758d76 Compare July 30, 2023 22:43
Copy link
Collaborator

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go! 🚀

@waldyrious waldyrious merged commit e1ceb2a into hamstar:master Jul 30, 2023
@Xymph Xymph deleted the prepare-release-1.1.0 branch July 31, 2023 07:25
@waldyrious
Copy link
Collaborator

waldyrious commented Jul 31, 2023

After merging the PR, I have performed the steps described in GOVERNANCE.md:

As a follow-up to having gone through this process, I created #157 to make the release instructions slightly clearer and more comprehensive; in particular, that added the recommendation to leave a comment like this, to keep an explicit record of the release steps taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants