Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace deprecated method #262

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor: replace deprecated method #262

wants to merge 1 commit into from

Conversation

jeerryy
Copy link

@jeerryy jeerryy commented Nov 1, 2023

Replace deprecated method scanFromPrototype to getAllMethodNames
and Remove unnecessary parameter.

@jeerryy
refactor: replace deprecated method
a854824 
scanFromPrototype -> getAllMethodNames
hanchchch
hanchchch approved these changes Nov 1, 2023
View reviewed changes
Copy link
Owner

@hanchchch hanchchch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanchchch hanchchch hanchchch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeerryy @hanchchch