Skip to content

Commit

Permalink
Pass correct environment for AWS S3 publishing
Browse files Browse the repository at this point in the history
See #1972
  • Loading branch information
jaylinski committed Jul 29, 2023
1 parent bb55dea commit ff10a0f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,15 @@ on:
push:
branches:
- master
- fix-aws-s3-publish-v3 # Delete me before merging!
tags:
- '*'

jobs:
publish-aws-s3:
name: Publish to AWS S3
runs-on: 'ubuntu-latest'
environment: 'builds.handlebarsjs.com.s3.amazonaws.com'
steps:
- name: Checkout
uses: actions/checkout@v2
Expand All @@ -31,6 +33,6 @@ jobs:
git config --global user.name "handlebars-lang"
npm run publish:aws
env:
# Note: the environment secrets `S3_ACCESS_KEY_ID`
# and `S3_SECRET_ACCESS_KEY` have to be set!
S3_BUCKET_NAME: "builds.handlebarsjs.com"
S3_ACCESS_KEY_ID: ${{ secrets.S3_ACCESS_KEY_ID }}
S3_SECRET_ACCESS_KEY: ${{ secrets.S3_SECRET_ACCESS_KEY }}

0 comments on commit ff10a0f

Please sign in to comment.