-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and stabilize column widths and row heights calculations #11049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Launch the local version of documentation by running: npm run docs:review 99027e0abba800fd641c7a0a27b6718487715948 |
budnix
changed the title
[wip] Change the column width calculations trigger places
Fix and stabilize column width calculation
Jul 2, 2024
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6351ab6:
|
budnix
changed the title
Fix and stabilize column width calculation
Fix and stabilize column widths and row heights calculations
Jul 3, 2024
jansiegel
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The PR fixes a bug that caused the viewport position to be incorrectly calculated when the viewport was scrolled and the row or column had a non-standard width/height defined. The bug was that the width/height calculations were triggered after the calculators were created, which caused viewport misalignment. Values calculated by the plugins were not taken into account when calculators calculated the viewport position (position of the
wtSpreader
element). The PR fixes this by moving the size calculations to a moment before calculators are created.Other changes:
GhostTable
from CSS rules fixed the issue (change);calculateVisibleRowsHeight
method to the AutoRowSize plugin. The same method already existed in the second AutoColumnSize plugin;clearCache
method for both plugins.How has this been tested?
I tested the changes locally and I covered the fix with new tests.
Types of changes
Related issue(s):
Affected project(s):
handsontable
Checklist: