Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smp surrogates encode #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ghard
Copy link

@ghard ghard commented Jan 28, 2016

According to the documentation found in the net [1], characters outside basic multilingual plane should be encoded using surrogate pairs.

This is minimally tested, but works on my use case where I need to feed EMOJI to a mobile client and my users were getting garbage displayed to them.

Optimally, the decoding side should probably be hacked to be able to do the reverse as well. I don't have need for this at the moment so haven't looked into it yet.

[1] http://www.ietf.org/rfc/rfc4627.txt "2.5 Strings"

@ghard
Copy link
Author

ghard commented Nov 3, 2016

Hi,

I don't have immediate need for the decoding, so it would be low priority, I'm afraid. Feel free to give it a shot! My pull request was submitted a while ago, with no reaction whatsoever though, so I don't know if this space is being watched or not :) maybe it needs a fork. I'm using my patch in production for a mobile app API backend and it does the trick I need it to do.

Cheers,
Yrjänä

Sent from my iPad

On 3 Nov 2016, at 14:32, Salad Tea [email protected] wrote:

I made a similar pull request, because didn't noticed yours. (#19)

Do you interested in implement surrogate pairs in the decoder.lisp?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant