Implement a selectMultipleAuthors setting which restricts author se…

…lection only to a single author when disabled.
hansu · Jan 23, 2024 · 87482ab · 87482ab
1 parent 15efc67
commit 87482ab
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1067,6 +1067,11 @@
 					"default": false,
 					"markdownDescription": "Only follow the first parent of commits when discovering the commits to load in the Git Graph View. See [--first-parent](https://git-scm.com/docs/git-log#Documentation/git-log.txt---first-parent) to find out more about this setting. This can be overridden per repository in the Git Graph View's Repository Settings Widget."
 				},
+				"git-graph.repository.selectMultipleAuthors": {
+					"type": "boolean",
+					"default": true,
+					"description": "Enables the selection of multiple authors from the Authors dropdown."
+				},
 				"git-graph.repository.selectMultipleBranches": {
 					"type": "boolean",
 					"default": true,

diff --git a/src/config.ts b/src/config.ts
@@ -450,6 +450,13 @@ class Config {
 		return !!this.getRenamedExtensionSetting('repository.onlyFollowFirstParent', 'onlyFollowFirstParent', false);
 	}
 
+	/**
+	 * Get the value of the `git-graph.repository.selectMultipleAuthors` Extension Setting.
+	 */
+	get selectMultipleAuthors() {
+		return !!this.config.get('repository.selectMultipleAuthors', true);
+	}
+
 	/**
 	 * Get the value of the `git-graph.repository.selectMultipleBranches` Extension Setting.
 	 */

diff --git a/src/gitGraphView.ts b/src/gitGraphView.ts
@@ -691,6 +691,7 @@ export class GitGraphView extends Disposable {
 				onRepoLoad: config.onRepoLoad,
 				referenceLabels: config.referenceLabels,
 				repoDropdownOrder: config.repoDropdownOrder,
+				selectMultipleAuthors: config.selectMultipleAuthors,
 				selectMultipleBranches: config.selectMultipleBranches,
 				showRemoteBranches: config.showRemoteBranches,
 				showStashes: config.showStashes,
@@ -719,12 +720,13 @@ export class GitGraphView extends Disposable {
 		} else if (numRepos > 0) {
 			const stickyClassAttr = initialState.config.stickyHeader ? ' class="sticky"' : '';
 			const branchDropdownLabel = initialState.config.selectMultipleBranches ? 'Branches' : 'Branch';
+			const authorDropdownLabel = initialState.config.selectMultipleAuthors ? 'Authors' : 'Author';
 			body = `<body>
 			<div id="view" tabindex="-1">
 				<div id="controls"${stickyClassAttr}>
 					<span id="repoControl"><span class="unselectable">Repo: </span><div id="repoDropdown" class="dropdown"></div></span>
 					<span id="branchControl"><span class="unselectable">${branchDropdownLabel}: </span><div id="branchDropdown" class="dropdown"></div></span>
-					<span id="authorControl"><span class="unselectable">Authors: </span><div id="authorDropdown" class="dropdown"></div></span>
+					<span id="authorControl"><span class="unselectable">${authorDropdownLabel}: </span><div id="authorDropdown" class="dropdown"></div></span>
 
 					<label id="showRemoteBranchesControl"><input type="checkbox" id="showRemoteBranchesCheckbox" tabindex="-1"><span class="customCheckbox"></span>Show Remote Branches</label>
 					<div id="currentBtn" title="Current"></div>

diff --git a/src/types.ts b/src/types.ts
@@ -261,6 +261,7 @@ export interface GitGraphViewConfig {
 	readonly onRepoLoad: OnRepoLoadConfig;
 	readonly referenceLabels: ReferenceLabelsConfig;
 	readonly repoDropdownOrder: RepoDropdownOrder;
+	readonly selectMultipleAuthors: boolean;
 	readonly selectMultipleBranches: boolean;
 	readonly showRemoteBranches: boolean;
 	readonly showStashes: boolean;

diff --git a/web/main.ts b/web/main.ts
@@ -93,7 +93,7 @@ class GitGraphView {
 			this.clearCommits();
 			this.requestLoadRepoInfoAndCommits(true, true);
 		});
-		this.authorDropdown = new Dropdown('authorDropdown', false, true, 'Authors', (values) => {
+		this.authorDropdown = new Dropdown('authorDropdown', false, this.config.selectMultipleAuthors, 'Authors', (values) => {
 			this.currentAuthors = values;
 			this.maxCommits = this.config.initialLoadCommits;
 			this.saveState();