feat: copy_bidirectional_with_timeout added#1
Open
dilitvinov wants to merge 2 commits into
Open
Conversation
Author
|
@cxw620 please, have a look 🙏 |
Contributor
|
I will test it locally when I have free time on this weekend. CI is broken because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add read-idle drain timeout to
copy_bidirectionalProblem
poll_splice_drainwaits for the source to become readable with no upper bound. If the remote peer stops sending data without closing the connection, the task parks indefinitely — no CPU is wasted, but the connection is never cleaned up.Solution
Introduce an optional read-idle timeout for the drain phase.
API
No timeout is applied by default — existing behaviour is unchanged, no breaking changes.
Any suggestions are welcomed!