Improve auth interceptor operation handling

[jamesagnew]

Fixes #6258

[github-actions]

Formatting check succeeded!

[codeforgreen]

This is an interesting fix. Thank you for addressing it.

I don't see a change to the behaviour in the AuthorizationInterceptor itself. I suppose the previous change in 7.4.0 caused the regression by un-intentionally revealing another bug because it eliminated usage of checking the contents of a response (Bundle) resource based on RequestDetails.

So it was like the decision was based on both request and response. And it looks like you made sure the authorization checks happen separately.

[gijsbert802]

Any update on this? I see 1 test failed in the pipeline, but when I run that test locally it passes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.55%. Comparing base (406db33) to head (5a27065).
Report is 74 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6278      +/-   ##
============================================
+ Coverage     83.54%   83.55%   +0.01%     
- Complexity    27432    27771     +339     
============================================
  Files          1707     1738      +31     
  Lines        106185   107433    +1248     
  Branches      13397    13488      +91     
============================================
+ Hits          88710    89770    +1060     
- Misses        11750    11879     +129     
- Partials       5725     5784      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jamesagnew]

Apologies - Once this was merged, we saw a few downstream test failures, so I had to back this out while I try to figure out why.

Second attempt at merging this will be on #6382