-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting started cleanup #59
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
50e08ff
Update commands in installation descriptions
openam c210c8d
Update riddle-random exapmle following linting rules
openam 10db735
Update curl commands and browser links to be more consistent
openam 8d063a2
Add note about prepopulated database issues
openam 28cb20a
Remove non-existent log line from migration example
openam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point: the migration directory will seem corrupt to knex when the user hasn't simply cloned the example repo, since it's expected the exact same migrations (i.e. by their timestamped filename) will exist. Something to think on, hmm! CC @zemccartney in case you have any ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled off an issue to track this so that we can land the rest of these updates: #60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, bummer. Sorry, y'all, thanks for catching @openam! Immediate idea is doing away with the prepopulated db and setting up some sort of seeding script — maybe an
onPreStart
extension? — in the example repo. So we could point people to that extension from the getting started tutorial to copy into their project if they so choose, assuming they were creating the example app manually vs. cloning the example repo. People might find it nice that they can see and edit the riddles content, too. I dunno, I'll mull it over a bit more