Stopgap fix for marked dependency issue #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Feb 20, 2023
package.json
Outdated
| "marked": "1.x.x", | ||
| "marked-terminal": "4.x.x", | ||
| "marked": "4.0.16", | ||
| "marked-terminal": "5.x.x", |
There was a problem hiding this comment.
The only v5 marked-terminal versions that have support for CJS usage is v5.1.0+, so I think we'll want something like this:
Suggested change
| "marked-terminal": "5.x.x", | |
| "marked-terminal": "^5.1.0", |
There was a problem hiding this comment.
Good catch - I'll push up a fix shortly.
devinivy
reviewed
Feb 20, 2023
| @@ -44,8 +44,8 @@ | |||
| "@hapipal/toys": "3.x.x", | |||
| "bin-v8-flags-filter": ">=1.2.0 <2", | |||
| "glob": "7.x.x", | |||
| "marked": "1.x.x", | |||
| "marked-terminal": "4.x.x", | |||
| "marked": "4.0.16", | |||
There was a problem hiding this comment.
Is there a special reason this version is pinned, or can we use ^4.0.16?
There was a problem hiding this comment.
The markdown parsing change comes in at 4.0.17, which breaks some of hpal's tests, so I pinned it to this specific version.
…I'm not a travis user, so this might get reverted
|
It turns out in npm v9 an aborted |
…at when running hpal new. Also update lab to pick up new global leak handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.