Skip to content

fix(cli): allow runtime permission mode escalation to bypassPermissions #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucharo wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(cli): allow runtime permission mode escalation to bypassPermissions #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/cli/src/backends/claude/remote/claudeRemoteAgentSdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ export async function claudeRemoteAgentSdk(opts: {
mcpServers: opts.mcpServers,
settingSources,
permissionMode: mappedPermissionMode,
allowDangerouslySkipPermissions: mappedPermissionMode === 'bypassPermissions',
allowDangerouslySkipPermissions: true,
Copy link
Contributor

@greptile-apps greptile-apps bot Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing test will now fail

The test in claudeRemoteAgentSdk.optionsAndHooks.test.ts:103 asserts:

expect((await runOnce('default'))?.allowDangerouslySkipPermissions).toBe(false);

With this change, allowDangerouslySkipPermissions is now always true, so this assertion will fail. The test (line 55) and its description — "sets allowDangerouslySkipPermissions only when permissionMode is bypassPermissions" — need to be updated to reflect the new behavior (e.g., assert true for all modes and rename the test case).

model: argOverrides.model ?? mode.model,
fallbackModel: argOverrides.fallbackModel ?? mode.fallbackModel,
maxTurns: argOverrides.maxTurns,
Expand Down