Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow configuring optional queue arguments #3239

Merged
merged 2 commits into from
Oct 25, 2023
Merged

allow configuring optional queue arguments #3239

merged 2 commits into from
Oct 25, 2023

Conversation

benjamonnguyen
Copy link
Contributor

@benjamonnguyen benjamonnguyen commented Oct 24, 2023 •
edited
Loading

Fixes #

Changes proposed in this pull request:

  • Allow configuring optional queue arguments in queue/rabbitmq_amqplib plugin

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@benjamonnguyen benjamonnguyen mentioned this pull request Oct 24, 2023
Closed
msimerson
msimerson requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@msimerson msimerson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can shorten up the code per the inline comments.

Also, not a bad idea to add a commented code block in rabbitmq_amqplib.ini with the available settings. That's often the first place an admin will go looking for knobs to twiddle.

@benjamonnguyen
Copy link
Contributor Author

@msimerson const cfg is set to the [rabbitmq] section, but I've made the statement inline as suggested and added more documentation!

msimerson
msimerson approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@msimerson msimerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msimerson msimerson merged commit 3f3a923 into haraka:master Oct 25, 2023
13 checks passed
@msimerson msimerson mentioned this pull request Dec 12, 2023
Merged
11 tasks
msimerson added a commit that referenced this pull request Feb 8, 2024
@msimerson
Release v3.0.3 (#3256)
2075b94 
### [3.0.3] - 2024-02-07

#### Added

- feat(auth_vpopmaild): when outbound, assure the envelope domain matches AUTH domain #3265
- docs(outbound): remove example setting outbound_ip #3253
- doc(Plugins.md): add pi-queue-kafka #3247
- feat(rabbitmq_amqplib): configurable optional queue arguments #3239
- feat(clamd): add x-haraka-virus header #3207

#### Fixed

- Fix: add empty string as param to .join() on bounce. #3237
- Update links in documentation #3234
- fix(ob/hmail):Add filename to the error for easy debugging
- fix(ob/queue): Ignore 'error.' prefixed files in the queue because corrupted

#### Changed

- docs(outbound): remove example of outbound_ip #3253
- transaction: simplify else condition in add_data #3252
- q/smtp_forward: always register get_mx hook #3204
- dep(pi-es): bump version to 8.0.2 #3206
- dep(redis): bump version to 4.6.7 #3193
- dep(pi-spf): bump version to 1.2.4
- dep(net-utils): bump version to 1.5.3
- dep(pi-redis): bump version to 2.0.6
- dep(tld): bump version to 1.2.0
- remove defunct config files: lookup_rdns.strict.ini, lookup_rdns.strict.timeout, lookup_rdns.strict.whitelist, lookup_rdns.strict.whitelist_regex, rcpt_to.blocklist, rdns.allow_regexps, rdns.deny_regexps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimerson msimerson msimerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjamonnguyen @msimerson