messagestream: don't send default settings #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msimerson
added a commit
to haraka/message-stream
that referenced
this pull request
Apr 3, 2024
- feat: use optional chaining (?.) & default params - remove eslint & mocha from devDeps (install as needed with npx) related to haraka/Haraka#3290
msimerson
force-pushed
the
message-stream-default
branch
from
b7970d9 to
ee17fd1
Compare
msimerson
force-pushed
the
message-stream-default
branch
from
3771926 to
4f47171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure most of these are anachronisms, left over from when message_stream didn't have robust options handling and one had to pass in an object or an exception was thrown. Now requests to message_stream.pipe have a default argument object
Checklist: