Conversation
b21dea5 to
0bb6b54
Compare
79d7306 to
543b112
Compare
- outbound/timer_queue: unref the setInterval - update test run scripts - run_tests: restore ability to test one module - bump haraka-config version
827d97d to
0bc80c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node --testhas sharp edges) but I expect the future is inevitablynode --test.assertmodule) needed to usenode --test.test/server.jsdoesn't exit. I found (with wtfnode) one setInterval that needed to be unref'ed. There's nothing still listening, so that one requires a deeper dive.Checklist: