Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: more async/await #3358

Merged
merged 1 commit into from
May 15, 2024
Merged

style: more async/await #3358

merged 1 commit into from
May 15, 2024

Conversation

msimerson
Copy link
Member

@msimerson msimerson commented May 12, 2024 •
edited
Loading

Changes proposed in this pull request:

  • es6(async/promise): pre_send_trans_email_respond, process_delivery
  • server:
    • es6(async) _graceful, get_smtp_server, setup_smtp_listeners
    • replace async.eachLimit with Promise.all batches
    • status: replace async.map with Promise.allSettled

Checklist:

  • docs updated
  • tests updated
  • Changes updated

@msimerson msimerson changed the title es6: replacing caolan/async with async/await es6: more async/await May 14, 2024
@msimerson msimerson changed the title es6: more async/await style: more async/await May 14, 2024
@msimerson msimerson marked this pull request as ready for review May 14, 2024 21:36
@msimerson
status: replace callbacks with promises & async/await
1a38a41 
- server: async/await in _graceful, setup_smtp_listeners, get_smtp_server
- remove caolan/async from setup_http_listeners
@msimerson msimerson merged commit aba0638 into master May 15, 2024
21 checks passed
@msimerson msimerson deleted the remove-async branch May 15, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msimerson