Fix startup race condition

[analogic]

Fixes #3366

Changes proposed in this pull request:

• making endpoint.bind() to async and awaiting in server.js

Checklist:

• docs updated
• tests updated
• Changes updated

[msimerson]

It looks like you also need to await here

[analogic]

PR tested on multiple instances, seems OK

2024-05-21 20:25:39.085531500  [NOTICE] [-] [server] Listening on [::0]:25
2024-05-21 20:25:39.085777500  [NOTICE] [-] [server] Switching from current gid: 0
2024-05-21 20:25:39.086551500  [NOTICE] [-] [server] New gid: 8
2024-05-21 20:25:39.086589500  [NOTICE] [-] [server] Switching from current uid: 0
2024-05-21 20:25:39.087241500  [NOTICE] [-] [server] New uid: 88

[msimerson]

LGTM.

I'd like to see one more change. Now that bind is async, I think we should be using fs/promises instead of sync calls:

diff --git a/endpoint.js b/endpoint.js
index 8154aef1..8f8e959a 100644
--- a/endpoint.js
+++ b/endpoint.js
@@ -1,7 +1,7 @@
 'use strict';
 // Socket address parser/formatter and server binding helper
 
-const fs = require('node:fs');
+const fs = require('node:fs/promises');
 const sockaddr = require('sockaddr');
 
 module.exports = function endpoint (addr, defaultPort) {

Since fs.exists has been deprecated for years, switch it to use fs.access or fs.stat before the await fs.unlink(path);

[msimerson]

or ignore errors when the file doesn't exist:

await fs.rm(this.path, { force: true });

[msimerson]

Suggested change

	return await new Promise((resolve, reject) => {
	return new Promise((resolve, reject) => {

There's no need to await here.

[analogic]

When I "grep node:fs" I didn't find many "promises" so I assumed it would be better not to change. I chose "rm" for simplicity...

[msimerson]

Thanks! Great job on the diagnosis and the fix.