gs_usb command-line support (and documentation updates and stability fixes) #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an.logger by treating channel like index when all other arguments are missing
zariiii9003
reviewed
Jun 16, 2024
| if index is None and address is None and bus is None: | ||
| index = channel | ||
|
|
||
| self.index = None |
There was a problem hiding this comment.
Make these additional index and bitrate attributes private (add '_'-prefix).
zariiii9003
reviewed
Jun 16, 2024
| devs = GsUsb.scan() | ||
| gs_usb = devs[self.index] | ||
| try: | ||
| gs_usb.set_bitrate(self.bitrate) |
There was a problem hiding this comment.
Is this really necessary? Seems weird to call these methods in shutdown(). The comment does not really explain much.
There was a problem hiding this comment.
Yeah... it unfortunately is. Right now every second time python-can gs_usb interface tries to use the device there is a USBError thrown.
Traceback (most recent call last):
File "C:\Users\Ben Gardiner\src\python-can\can\interfaces\gs_usb.py", line 65, in __init__
self.gs_usb.start()
File "C:\Users\Public\miniconda3\Lib\site-packages\gs_usb\gs_usb.py", line 50, in start
self.gs_usb.reset()
File "C:\Users\Public\miniconda3\Lib\site-packages\usb\core.py", line 961, in reset
self._ctx.backend.reset_device(self._ctx.handle)
File "C:\Users\Public\miniconda3\Lib\site-packages\usb\backend\libusb0.py", line 618, in reset_device
_check(_lib.usb_reset(dev_handle))
File "C:\Users\Public\miniconda3\Lib\site-packages\usb\backend\libusb0.py", line 447, in _check
raise USBError(errmsg, ret)
usb.core.USBError: [Errno None] b'libusb0-dll:err [reset] could not reset device, win error: A device attached to the system is not functioning.\r\n\n'
I don't fully understand why though so the hamfisted way to fix it is to do the second open (start) that we know will fail in the shutdown method.
zariiii9003
reviewed
Jun 16, 2024
| @@ -8,13 +8,14 @@ and candleLight USB CAN interfaces. | |||
|
|
|||
| Install: ``pip install "python-can[gs_usb]"`` | |||
|
|
|||
| Usage: pass device ``index`` (starting from 0) if using automatic device detection: | |||
| Usage: pass device ``index`` or ``channel`` (starting from 0) if using automatic device detection: | |||
|
|
|||
| :: | |||
|
|
|||
| import can | |||
|
|
|||
| bus = can.Bus(interface="gs_usb", channel=dev.product, index=0, bitrate=250000) | |||
There was a problem hiding this comment.
Not related to your change, but dev is referenced before assignment here. Maybe you could improve this, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with these changes it is now possible to use the gs_usb driver with e.g. can.logger from the command line (like many other interfaces) with
python -m can.logger -i gs_usb -c 0 -b 500000