-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end count to send periodic in BCM #995
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #995 +/- ##
===========================================
- Coverage 70.38% 69.45% -0.93%
===========================================
Files 70 76 +6
Lines 6841 7403 +562
===========================================
+ Hits 4815 5142 +327
- Misses 2026 2261 +235 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to connect the socketcan CyclicSendTask too if you're up for it?
A new test in simplecyclic_test.py
would be appreciated too
@@ -104,6 +104,7 @@ def __init__( | |||
messages: Union[Sequence[Message], Message], | |||
period: float, | |||
duration: Optional[float], | |||
count: Optional[int], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
count: Optional[int], | |
count: Optional[int] = None, |
self.bus = bus | ||
self.send_lock = lock | ||
self.stopped = True | ||
self.thread = None | ||
self.end_time = time.perf_counter() + duration if duration else None | ||
self.end_count = count if count else None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.end_count = count if count else None | |
self.end_count = count |
Sure will modify your suggestions and try to add a test aswell. |
@zorce You can also just click on "Commit Suggestion" right from the GUI to apply the changes by hardbyte. |
@zorce Some conflicts have popped up by now. |
Add possibility to send periodic messages with a stop count as a criteria to facilitate one of sequences.
Closes #992