Bugfix: Fix for handle AT_FDCWD for readlinkat (#209)

* check for fd < 0 * fixed readlinkat to handle AT_FDCWD
hariharan-devarajan · Sep 30, 2024 · d9757dc · d9757dc
1 parent 8971c82
commit d9757dc
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/src/dftracer/brahma/posix.cpp b/src/dftracer/brahma/posix.cpp
@@ -382,11 +382,21 @@ ssize_t brahma::POSIXDFTracer::readlink(const char *path, char *buf,
 ssize_t brahma::POSIXDFTracer::readlinkat(int fd, const char *path, char *buf,
                                           size_t bufsize) {
   BRAHMA_MAP_OR_FAIL(readlinkat);
-  DFT_LOGGER_START(fd);
-  DFT_LOGGER_UPDATE(fd);
-  DFT_LOGGER_UPDATE(bufsize);
-  ssize_t ret = __real_readlinkat(fd, path, buf, bufsize);
-  DFT_LOGGER_END();
+  ssize_t ret;
+  if (fd != AT_FDCWD) {
+    DFT_LOGGER_START(fd);
+    DFT_LOGGER_UPDATE(fd);
+    DFT_LOGGER_UPDATE(path);
+    DFT_LOGGER_UPDATE(bufsize);
+    ret = __real_readlinkat(fd, path, buf, bufsize);
+    DFT_LOGGER_END();
+  } else {
+    DFT_LOGGER_START(path);
+    DFT_LOGGER_UPDATE(fd);
+    DFT_LOGGER_UPDATE(bufsize);
+    ret = __real_readlinkat(fd, path, buf, bufsize);
+    DFT_LOGGER_END();
+  }
   return ret;
 }
 

diff --git a/src/dftracer/brahma/posix.h b/src/dftracer/brahma/posix.h
@@ -30,7 +30,7 @@ class POSIXDFTracer : public POSIX {
   bool trace_all_files;
 
   inline uint16_t is_traced(int fd, const char *func) {
-    if (fd == -1) return 0;
+    if (fd < 0) return 0;
     uint16_t trace = tracked_fd[fd % MAX_FD];
     if (trace != 0) {
       DFTRACER_LOG_DEBUG(