-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Support analyzer to load traces with hashed fields #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
helloaashish
commented
Oct 2, 2024
- added conditions to find metadata events and handle storing the hash keys and values
- bugfix on corona configuration file to get correct number of workers.
hariharan-devarajan
requested changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u please revert the changes u did by mistake during merge.
hariharan-devarajan
requested changes
Oct 3, 2024
'compute_time': "string[pyarrow]" if not conf.time_approximate else "uint64[pyarrow]", | ||
'io_time': "string[pyarrow]" if not conf.time_approximate else "uint64[pyarrow]", | ||
'app_io_time': "string[pyarrow]" if not conf.time_approximate else "uint64[pyarrow]", | ||
'total_time': "string[pyarrow]" if not conf.time_approximate else "uint64[pyarrow]", | ||
'filename': "string[pyarrow]", | ||
'fhash': "uint32[pyarrow]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
'fhash': "uint32[pyarrow]", | |
'fhash': "uint64[pyarrow]", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.