fix(webview): release controller references safely - #69
Merged
Conversation
richerfu
added a commit
that referenced
this pull request
Aug 5, 2026
Resolve conflicts with main's fix(webview): release controller references safely (#69): - helper/webview.rs: keep the pluginized deletion. The fix (Rc<RefCell<Option<ObjectRef>>> + release_native_ref) addressed the legacy helper where Rust held ArkTS controller references; the pluginized crates/plugin-webview never keeps an ObjectRef, so the fix's goal is achieved by architecture. Its content is identical to the already-merged bd66a48. - demo_native lib.rs: keep the pluginized version; main's hunk uses the removed legacy helper API (Webview/WebViewBuilder/WebProxyBuilder).
richerfu
added a commit
that referenced
this pull request
Aug 5, 2026
…pr63-pluginized - bridge: adopt main's call_sync_from_worker (worker -> main-thread sync via TSFN) plus tsfn_sync_bridge demo wiring - packages: rename all plugins to @ohos-rs/ability-plugin-* and bump to 1.0.0-beta.0 (author/keywords/repository metadata) matching main's published form; drop the libnative_ability.so dependency from native_ability and plugin lockfiles - keep PR #63 pluginization: clipboard/menu/statusbar/updater/version crates and HARs, evolved webview/window/app-control plugins, demo registrations - delete legacy package/ staging dir (main removed it; workspace excludes it) - docs: fold main's call_sync_from_worker guidance into AGENTS.md and plugin-development-standard.md Co-Authored-By: Claude <noreply@anthropic.com>
ljy9812
pushed a commit
to ljy9812/openharmony-ability
that referenced
this pull request
Aug 22, 2026
…on and plugin migrations - pluginize native bridge capabilities (harmony-contrib#67), normalize node surface (harmony-contrib#70), transparent XComponent background (harmony-contrib#73), webview controller release safety (harmony-contrib#69) - plugin module agnostic refactor (harmony-contrib#75), serialize ability plugin lifecycle (harmony-contrib#74) - account/updater bridge migration and clipboard write-html API - dead code cleanup superseded by the bridge plugin architecture - deps upgrade, format + git hook Co-Authored-By: Claude <noreply@anthropic.com>
ljy9812
pushed a commit
to ljy9812/openharmony-ability
that referenced
this pull request
Aug 27, 2026
…on and plugin migrations - pluginize native bridge capabilities (harmony-contrib#67), normalize node surface (harmony-contrib#70), transparent XComponent background (harmony-contrib#73), webview controller release safety (harmony-contrib#69) - plugin module agnostic refactor (harmony-contrib#75), serialize ability plugin lifecycle (harmony-contrib#74) - account/updater bridge migration and clipboard write-html API - dead code cleanup superseded by the bridge plugin architecture - deps upgrade, format + git hook Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.