fix(backend): validate Stellar account and contract identifiers #20 - #235
Merged
enliven17 merged 1 commit intoJul 29, 2026
Conversation
…crates-stellar#20 Add Stellar StrKey validation to the proof registration endpoint. - Implement StrKey base32 decoding and CRC16-XMODEM checksum verification in backend/strkey.py - Validate G-addresses (sourceAddress) and C-contract IDs (contractId) with proper Stellar StrKey semantics - Allow explicitly nullable fields (None accepted for both) - Return field-specific error messages on invalid input - Add 36 unit tests covering valid checksums, wrong types, malformed values, nullable handling, and case-insensitive input - Update existing test fixtures with valid Stellar addresses - Fix pre-existing missing function imports in db.py Closes harpocrates-stellar#20
|
@abrahambaba1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
enliven17
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Stellar StrKey validation to the proof registration endpoint to prevent malformed source and contract identifiers from being stored.
Changes
backend/strkey.py— Implements base32 decoding/encoding and CRC16-XMODEM checksum verification for Stellar G-addresses and C-contract IDsbackend/app.py— Register endpoint now validatessourceAddressandcontractIdwith field-specific error messages; allowsnullfor both fieldsbackend/test_strkey.py— 36 unit tests covering valid checksums, wrong types, tampered payloads, invalid characters, wrong length, nullable handling, and case-insensitive normalization (all pass)backend/test_app.py— Updated test fixtures with properly valid Stellar addressesbackend/load_test.py— Synthetic load test payloads omit sourceAddress/contractIdbackend/db.py— Added pre-existing missing functions (set_legal_hold, purge_expired_events, enqueue_job, get_job, cancel_job)Acceptance Criteria
Closes #20