-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor widget prefs 6177951123037805482 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6977c84
Refactor to Jetpack Compose, Hilt, and Room
google-labs-jules[bot] 930db66
Update app/src/main/java/com/example/theloop/ui/HomeScreen.kt
harrydbarnes 7a4d79e
Update app/src/main/java/com/example/theloop/WidgetUpdateWorker.kt
harrydbarnes 32d9ba5
Update app/src/main/java/com/example/theloop/DayAheadWidget.kt
harrydbarnes ecb0bd7
Update app/src/main/java/com/example/theloop/MainViewModel.kt
harrydbarnes 07902c5
Update app/src/main/java/com/example/theloop/WidgetUpdateWorker.kt
harrydbarnes bbe79e9
Update app/src/main/java/com/example/theloop/ui/HomeScreen.kt
harrydbarnes 2ecb8a4
Fix permissions handling, date formatting, and logging
google-labs-jules[bot] 9fc1842
Fix permissions, formatting, logging, and data safety
google-labs-jules[bot] dbbfb83
Fix permissions, formatting, logging, and data safety
google-labs-jules[bot] 15ddb3e
Update app/src/main/java/com/example/theloop/data/repository/Calendar…
harrydbarnes 8408e80
Update app/src/main/java/com/example/theloop/DayAheadWidget.kt
harrydbarnes 93d6bf7
Fix permissions, formatting, logging, and data safety
google-labs-jules[bot] 824fb9d
Fix permissions, formatting, logging, build issues, and code quality
google-labs-jules[bot] 198052f
Fix permissions, formatting, logging, build issues, and code quality
google-labs-jules[bot] 0a419f9
Fix race condition in MainViewModel and refactor DayAheadWidget
google-labs-jules[bot] 20ff987
Refactor MainViewModel to use Repository pattern and fix race condition
google-labs-jules[bot] 8311584
Update app/src/main/java/com/example/theloop/MainViewModel.kt
harrydbarnes 087a507
Refactor widget and worker to use UserPreferencesRepository
google-labs-jules[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ | |
| <uses-permission android:name="android.permission.health.READ_STEPS" /> | ||
|
|
||
| <application | ||
| android:name=".TheLoopApplication" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| android:allowBackup="true" | ||
| android:icon="@mipmap/ic_launcher" | ||
| android:label="@string/app_name" | ||
|
|
||
283 changes: 0 additions & 283 deletions
283
app/src/main/java/com/example/theloop/DashboardAdapter.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see Hilt integrated for dependency injection. However, ensure that
kotlin-kaptis applied beforedagger.hilt.androidto avoid potential issues with annotation processing order.