fix(editor): add 'graph' to the activity bar tab union (Closes #138) - #173
Merged
harsharajkumar-273 merged 1 commit intoAug 4, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (1)
📝 WalkthroughWalkthrough
ChangesEditor activity bar
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
harsharajkumar-273
approved these changes
Aug 4, 2026
harsharajkumar-273
merged commit Aug 4, 2026
1a0d246
into
harsharajkumar-273:main
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #138
Cause
frontend/package.jsondefines"build": "tsc -b && vite build", andEditorPage.tsxdeclares the activity bar tab as a closed union:'graph'is not a member, but the render branch compares against it:That is TS2367 — a comparison between types with no overlap — which
tsc -btreats as an error. It failsnpm run build, and thereforeRUN NODE_OPTIONS=--max-old-space-size=1536 npm run buildat line 16 ofdocker/Dockerfile.nginx, which is the step this issue reports.It arrived with #152, which added
EditorGraphPaneand this branch without widening the union.Change
'graph'added to the union.Something I found while fixing it
'graph'appears exactly once inEditorPage.tsx— that comparison. There is nosetActivityBarTab('graph')anywhere, no entry in thepanesarray at line ~2022 that backs the command palette, and no activity bar button.So after this change the build passes, but
EditorGraphPanestill cannot be opened by any user action — the branch is unreachable. This PR fixes the build failure the issue is about; it does not make the feature usable.I'd rather flag that than quietly widen the type and leave dead UI. Two options if you want it wired up:
{ id: 'graph', label: 'Graph Explorer' }topanes, which makes it reachable from the command palette — a small addition I can fold in here; orSay which and I'll do it.
Verification
npm run build --prefix frontend— fulltsc -b && vite build— completes successfully on this branch (2494 modules transformed, built in 19.4s). The same command fails on main with TS2367 atEditorPage.tsx:3197.'graph'is a member.Summary by CodeRabbit