chore: remove orphaned node-pty remnants and reconcile the README (Closes #132) - #174
Conversation
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Comment |
bfa7e0e
into
harsharajkumar-273:main
Closes #132
What was left over
The terminal feature was removed from the code but not from everything describing it:
node-pty@^1.1.0is inbackend/package.jsonand imported by nothing.node-ptyis a native module, so every contributor and every CI run pays to compile it for no benefit.PROOFDESK_TERMINAL_MODEandPROOFDESK_TERMINAL_RUNTIMEare set indocker-compose.prod.ymland read by no code.README.mddocuments the feature as current in four places, including the architecture diagram.That last one is why this matters beyond tidiness: #125 and #132 are both security-shaped reports filed against a file that doesn't exist, because the documentation still describes an attack surface the code doesn't have.
Change
backend/package.json—node-ptyremoved. The other 24 dependencies are untouched.docker-compose.prod.yml— the two dead variables removed.README.md— the terminal claims now describe the mechanism that actually ships. Build output reaches the client over Server-Sent Events:GET /build/logs/:sessionIdsetsContent-Type: text/event-stream(build.controller.ts:94) andBuildLogPanel.tsx:59consumes it withEventSource. I checked that path before rewriting rather than guessing.Four edits: the overview paragraph, the section heading and its streaming bullet, the Mermaid node, and the sandbox description. The prose around them is unchanged.
Left alone deliberately
Line 150 still reads "prune dangling Docker PTY sockets" in the roadmap. It's a future item rather than a description of current behaviour, and rewording someone's roadmap felt out of scope — say the word if you'd like it updated too.
Verification
backend/package.jsonstill parses as valid JSON; 24 dependencies remain.node-ptyreference survives in any of the three files.grepacrossbackend/srcreturns nothing).backend/package-lock.jsonregenerated in the same commit andnpm ci --dry-runresolves cleanly, so the lockfile and manifest stay consistent for CI.Worth noting
backend/package-lock.jsonneeds regenerating alongside this sonpm cistays consistent — I've handled that in the same commit.