Skip to content

fix(a11y): add visible focus rings to footer links (Closes #122) #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SakethSumanBathini wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −7
Open

fix(a11y): add visible focus rings to footer links (Closes #122) #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions frontend/src/components/LandingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,11 +406,22 @@ const LandingPage: React.FC<LandingPageProps> = ({ hasWorkspaceAccess, entryNoti
<span>© 2026</span>
</div>
<div className="flex items-center gap-6">
<a href="https://github.com/harsharajkumar/proofdesk" target="_blank" rel="noopener noreferrer" className="flex items-center gap-1.5 hover:text-zinc-700 dark:hover:text-zinc-300 transition-colors">
<Github className="w-4 h-4" /> GitHub
{/* A visible focus ring on every footer link.
Keyboard users previously had only the browser default, which
is nearly invisible against these muted greys. Matches the
convention already used in EditorImportPane. */}
<a
href="https://github.com/harsharajkumar/proofdesk"
target="_blank"
rel="noopener noreferrer"
title="View Proofdesk on GitHub (opens in a new tab)"
className="flex items-center gap-1.5 hover:text-zinc-700 dark:hover:text-zinc-300 transition-colors outline-none focus-visible:ring-2 focus-visible:ring-indigo-500 focus-visible:ring-offset-2 dark:focus-visible:ring-offset-zinc-950 rounded-sm"
>
<Github className="w-4 h-4" aria-hidden="true" /> GitHub
<span className="sr-only">(opens in a new tab)</span>
</a>
<Link to="/terms" className="hover:text-zinc-700 dark:hover:text-zinc-300 transition-colors">Terms</Link>
<Link to="/privacy" className="hover:text-zinc-700 dark:hover:text-zinc-300 transition-colors">Privacy</Link>
<Link to="/terms" className="hover:text-zinc-700 dark:hover:text-zinc-300 transition-colors outline-none focus-visible:ring-2 focus-visible:ring-indigo-500 focus-visible:ring-offset-2 dark:focus-visible:ring-offset-zinc-950 rounded-sm">Terms</Link>
<Link to="/privacy" className="hover:text-zinc-700 dark:hover:text-zinc-300 transition-colors outline-none focus-visible:ring-2 focus-visible:ring-indigo-500 focus-visible:ring-offset-2 dark:focus-visible:ring-offset-zinc-950 rounded-sm">Privacy</Link>
</div>
</div>
</footer>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/LegalPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ const LegalPage: React.FC<LegalPageProps> = ({ title, lastUpdated, sections }) =
<div className="max-w-4xl mx-auto flex items-center justify-between text-sm text-zinc-400">
<span>© 2026 {PRODUCT_NAME}</span>
<div className="flex gap-5">
<Link to="/terms" className="hover:text-zinc-600 dark:hover:text-zinc-300 transition-colors">Terms</Link>
<Link to="/privacy" className="hover:text-zinc-600 dark:hover:text-zinc-300 transition-colors">Privacy</Link>
<Link to="/" className="hover:text-zinc-600 dark:hover:text-zinc-300 transition-colors">Home</Link>
<Link to="/terms" className="hover:text-zinc-600 dark:hover:text-zinc-300 transition-colors outline-none focus-visible:ring-2 focus-visible:ring-indigo-500 focus-visible:ring-offset-2 dark:focus-visible:ring-offset-zinc-950 rounded-sm">Terms</Link>
<Link to="/privacy" className="hover:text-zinc-600 dark:hover:text-zinc-300 transition-colors outline-none focus-visible:ring-2 focus-visible:ring-indigo-500 focus-visible:ring-offset-2 dark:focus-visible:ring-offset-zinc-950 rounded-sm">Privacy</Link>
<Link to="/" className="hover:text-zinc-600 dark:hover:text-zinc-300 transition-colors outline-none focus-visible:ring-2 focus-visible:ring-indigo-500 focus-visible:ring-offset-2 dark:focus-visible:ring-offset-zinc-950 rounded-sm">Home</Link>
</div>
</div>
</footer>
Expand Down
Loading