Add resource to manage version of freshclam package installed as well #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change itself looks good to me. The build only failed because the security policies in Travis. But could you add this change to the ChefSpec tests for the cookbook? At a glance, it should just be adding the new package to https://github.com/RoboticCheese/clamav-chef/blob/master/spec/unit/recipes/install_deb_spec.rb#L6. Thanks! |
|
Will do. Looking closer, shall I add it to the install_rpm recipe and tests as well? Thx! |
|
Nm...looks like freshclam is installed as part of clamav via yum |
|
Ok @RoboticCheese , added test changes and kitchen tested. Thanks! |
|
Looks good. Thanks! |
hartmantis
added a commit
that referenced
this pull request
Jul 3, 2014
Add resource to manage version of freshclam package installed as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #34.