Date and Time Updates: SimpleDateChooser allow both past and future, time picker #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabeabrams
commented
Mar 17, 2025
src/components/SimpleDateChooser.tsx
Outdated
| // Number of months to allow the user to choose from | ||
| // (max is 12, default is 6) | ||
| // Number of months in either the past or future to allow the user to choose from | ||
| // If we aren't allowing the past or the future, we will only show the present date |
There was a problem hiding this comment.
Instead, please throw an error (it doesn't make sense to have a chooser that only allows selecting one date).
src/components/SimpleDateChooser.tsx
Outdated
| // If true, instead of showing numMonthsToShow months into the future, | ||
| // show numMonthsToShow months into the past | ||
| chooseFromPast?: boolean, | ||
| // Determine if past dates are allowed to be chosen |
There was a problem hiding this comment.
Standard language: If true, the user isn't allowed to select dates in the past
Same for below
src/components/SimpleDateChooser.tsx
Outdated
| endMonth += Math.max(0, numMonthsToShow - 1); | ||
| while (endMonth > 12) { | ||
| endMonth -= 12; | ||
| endYear += 1; |
There was a problem hiding this comment.
For some reason, endYear an unused variable. Is there a problem with the implementation? Or is this variable truly not needed?
src/components/SimpleDateChooser.tsx
Outdated
| // Calculate total number of months to show | ||
| let totalMonthsToShow = numMonthsToShow; | ||
| if (!dontAllowPast && !dontAllowFuture) { | ||
| totalMonthsToShow = totalMonthsToShow * 2; |
src/components/SimpleDateChooser.tsx
Outdated
| for (let day = 1; day < today.day; day++) { | ||
| days.push(day); | ||
| } | ||
| } |
There was a problem hiding this comment.
Remove trailing space
src/components/SimpleDateChooser.tsx
Outdated
| @@ -76,16 +80,36 @@ const SimpleDateChooser: React.FC<Props> = (props) => { | |||
| days: number[], | |||
| year: number, | |||
| }[] = []; | |||
| // TODO: update logic to be able to generate either/or/and past + future | |||
There was a problem hiding this comment.
Can you explain this TODO? Isn't this the mission of the current work?
gabeabrams
commented
Mar 17, 2025
gabeabrams
force-pushed
the
f/date-and-time-updates
branch
from
5156d34 to
2ef2f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.