F/log reviewer server side filter #35
Open
+3,046
−2,859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/harvard-edtech/dce-reactkit into f/log-reviewer-server-side-filter
gabeabrams
reviewed
Mar 25, 2025
gabeabrams
reviewed
Mar 25, 2025
| currentPage, | ||
| numPages, | ||
| loading = false, | ||
| onPageChanged, |
There was a problem hiding this comment.
Missing the template /* Setup */ block
There was a problem hiding this comment.
See template. This is close but still not the same as our template
gabeabrams
requested changes
Mar 25, 2025
src/components/Pagination.tsx
Outdated
| pages.push(i); | ||
| } | ||
| return pages; | ||
| }; |
There was a problem hiding this comment.
Doesn't need to be a function
src/components/Pagination.tsx
Outdated
| const pages = getPageNumbers(); | ||
|
|
||
| return ( | ||
| <nav aria-label="Page navigation" className="mt-3"> |
There was a problem hiding this comment.
Give the aria-label a more specific, descriptive text
src/components/LogReviewer.tsx
Outdated
| }, | ||
| [], | ||
| ); | ||
| // Fetch logs on mount |
src/components/LogReviewer.tsx
Outdated
| onClick={() => { | ||
| // Save active filters | ||
| activeFiltersRef.current = { | ||
| dateFilterState: JSON.parse( |
There was a problem hiding this comment.
Add comment describing the fact that we need to duplicate state
src/components/LogReviewer.tsx
Outdated
| // Save active filters | ||
| activeFiltersRef.current = { | ||
| dateFilterState: JSON.parse( | ||
| JSON.stringify(pendingDateFilterState), |
There was a problem hiding this comment.
Make a helper function to clone a JSON object
| year={pendingDateFilterState.endDate.year} | ||
| month={pendingDateFilterState.endDate.month} | ||
| day={pendingDateFilterState.endDate.day} | ||
| chooseFromPast |
There was a problem hiding this comment.
This should be an error if rebase was successful. Is it?
src/components/LogReviewer.tsx
Outdated
| <LoadingSpinner /> | ||
| </div> | ||
| ) | ||
| } |
gabeabrams
reviewed
Mar 27, 2025
| @@ -0,0 +1,6 @@ | |||
| // Tag filter state | |||
There was a problem hiding this comment.
For all your types, switch to JSDoc and add your Author tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.