This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Handle export errors #2195
Closed
Handle export errors #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensteinberg
requested review from
teovin and
jcushman
and removed request for
a team
|
Since we will be gracefully handling the error so the execution continues instead of erroring out and stopping, I think it would be good to log the error inside the except block for informational purposes, future troubleshooting etc. Also, Jack might have some background on why this error might be being thrown now, I assume the underlying data doesn't change very frequently. |
|
Logging would be a good idea, but I'm going to close this PR, as @jcushman is going to look into the underlying problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should address #2194.