This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Update cite extraction #2201
Merged
Update cite extraction #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensteinberg
suggested changes
Feb 27, 2024
jcushman
force-pushed
the
fix-cite-markup
branch
from
7b38c23
to
3a11207
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2201 +/- ##
========================================
Coverage 63.68% 63.68%
========================================
Files 107 107
Lines 11820 11821 +1
========================================
+ Hits 7527 7528 +1
Misses 4293 4293 ☔ View full report in Codecov by Sentry. |
bensteinberg
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of errors in my previous fix to the html errors in cite extraction -- I tested by running the old and new version on all Mass. cases.
This also makes two substantive changes:
data-case-ids, so cite extraction produces consistent output from run to run.data-cite="<corrected citation>"to each cite link, so you can link from extracted cites to a search page.